Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: merge mixins options" #273

Merged
merged 1 commit into from
Sep 29, 2018
Merged

Revert "feat: merge mixins options" #273

merged 1 commit into from
Sep 29, 2018

Conversation

manniL
Copy link
Member

@manniL manniL commented Sep 28, 2018

This reverts commit ad4d61c.

Sorry for the problems and inconveniences caused!

Resolves #269 nuxt-modules/i18n#127 nuxt/nuxt#3957

@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #273 into master will decrease coverage by 1.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #273      +/-   ##
=========================================
- Coverage   41.57%   40.3%   -1.27%     
=========================================
  Files          18      18              
  Lines         267     263       -4     
=========================================
- Hits          111     106       -5     
- Misses        156     157       +1
Impacted Files Coverage Δ
src/shared/plugin.js 51.72% <ø> (-1.61%) ⬇️
src/shared/getComponentOption.js 100% <100%> (ø) ⬆️
src/shared/getMetaInfo.js 94.64% <0%> (-1.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8830f1b...73c1ee3. Read the comment docs.

@bdrtsky
Copy link

bdrtsky commented Apr 3, 2019

So, merging is not working? I am trying to use head from mixin with Nuxt and it doesn't work.

@manniL
Copy link
Member Author

manniL commented Apr 20, 2019

We had to revert that PR because it broke reactivity here and there.
Feel free to create another issue if there is none yet @bdrtsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.5.4 breaks metaInfo reactivity
3 participants